Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Destroying player object removes observers. #3085

Open
wants to merge 3 commits into
base: develop-2.0.0
Choose a base branch
from

Conversation

samlucas-unity
Copy link
Contributor

Resolves issue when a player object is destroyed leaving the client connection intact - observers would be removed from network objects and not restored when a new player object is created for that client.

This issue affected 2.0.0 only.

fix: #3059

Changelog

  • Fixed: Destroying the clients player object would cause it to be removed from NetworkObject observers list and wouldn't restore them when the player object was recreated. Fixes regression from 1.11.

Testing and Documentation

  • Includes integration test PlayerSpawnNoObserversTest.SpawnDestoryRespawnPlayerObjectMaintainsObservers.
  • No documentation changes or additions were necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant