Add Yamato configs #1172
Merged
Add Yamato configs #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kicked off Yamato builds on squashed commit. I will link the pipeline before merge. |
joshpeterson
approved these changes
May 2, 2019
|
Can we add the Yamato builds as checks for Github PRs? |
joncham
reviewed
May 2, 2019
| sudo apt-get install -y schroot | ||
| sudo apt-get install -y binutils debootstrap | ||
| git submodule update --init --recursive | ||
| git submodule update --init --recursive |
There was a problem hiding this comment.
Its failing sometimes due to network issues and retry also fails. So manually trying twice. Only on linux.
There was a problem hiding this comment.
Then minor, but can we use loop and check exit code a few times?
joncham
reviewed
May 2, 2019
| sudo apt-get install -y libc6-dev-i386 | ||
| sudo apt-get install -y libncurses5-i386 | ||
| git submodule update --init --recursive | ||
| git submodule update --init --recursive |
joncham
reviewed
May 2, 2019
.yamato/build_win.yml
Outdated
| interpreter: powershell | ||
|
|
||
| commands: | ||
| - git submodule update --init --recursive |
There was a problem hiding this comment.
Might be nice to have windows like other platforms where all logic is in a script, and the yml calls a single command. I think this also helps capture all output.
joncham
approved these changes
May 2, 2019
ashwinimurt
force-pushed
the
unity-master-yamato
branch
5 times, most recently
from
c3d909d
to
e3dc8a9
Compare
ashwinimurt
force-pushed
the
unity-master-yamato
branch
from
d2eb5b3
to
0b341d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on commit before squash: https://yamato.prd.cds.internal.unity3d.com/jobs/81-mono/tree/unity-master-yamato/.yamato%252Fcollate_builds.yml/96720/job/pipeline