Use bokken runner for windows builds #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinimurt
commented
May 8, 2019
| @@ -40,6 +40,11 @@ sub CompileVCProj | |||
| my $config; | |||
|
|
|||
| my $msbuild = $ENV{"ProgramFiles(x86)"}."/MSBuild/$msBuildVersion/Bin/MSBuild.exe"; | |||
|
|
|||
| if ((! -d $extraBuildTools) || ($ENV{YAMATO_PROJECT_ID}) || ($ENV{USERNAME} == "bokken")) | |||
There was a problem hiding this comment.
We want to use 15.0 on Yamato (where YAMATO_PROJECT_ID is set) and GitLabCI Bokken runners (where username is "bokken").
Buildfarm runners have 14.0.
joshpeterson
approved these changes
May 8, 2019
joncham
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Buildfarm runners are currently broken. Switch to bokken.
Tested on a commit before squash:
Win64: https://gitlab.cds.internal.unity3d.com/vm/mono/-/jobs/306706
Win32: https://gitlab.cds.internal.unity3d.com/vm/mono/-/jobs/306707
BareMininum: https://gitlab.cds.internal.unity3d.com/vm/mono/-/jobs/306708