Use the non-server default connection limit for unityaot (case 1156607) #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncham
approved these changes
May 28, 2019
The default value for `DefaultConnectionLimit`, which is set based on the `DefaultPersistentConnectionLimit` value should be 2 for all non-ASP.NET applications. So for the unityaot profile, used with IL2CPP, use the value of 2.
joshpeterson
force-pushed
the
change-default-connection-limit
branch
from
3b4e916
to
f41e565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for
DefaultConnectionLimit, which is set based onthe
DefaultPersistentConnectionLimitvalue should be 2 for allnon-ASP.NET applications.
So for the unityaot profile, used with IL2CPP, use the value of 2.
Release notes:
IL2CPP: Set the ServicePointManager DefaultConnectionLimit property to a value of 2. (case 1156607).
I'll back port this change to 2019.2 and 2019.1.