Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NamedPipeClientStream in the unityaot profile (case 1159863) #1192

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

joshpeterson
Copy link

@joshpeterson joshpeterson commented Jun 5, 2019

This change builds the class library code to implement the
NamedPipeClientStream class in the unityaot profile on Windows. For
the time being, we will not implement this class for non-Windows
platforms, since that requires the Mono.Posix.dll assembly and a native
library as well.

We may consider adding support on Posix platforms in the future.

Release notes:

IL2CPP: Add support for NamedPipeClientStream on Windows platforms. (case 1159863)

I'll backport this change to 2019.2, 2019.2, and 2018.4.

@joshpeterson joshpeterson requested a review from joncham June 5, 2019 14:05
throw new NotImplementedException ();
#else
if (IsWindows)
impl = new Win32NamedPipeClient (this, serverName, pipeName, desiredAccessRights, options, inheritability);
else
#if UNITY
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want UNITY_AOT here instead? This will affect unityjit as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, good point. I'll change these to be UNITY_AOT.

This change builds the class library code to implement the
`NamedPipeClientStream` class in the unityaot profile on Windows. For
the time being, we will not implement this class for non-Windows
platforms, since that requires the Mono.Posix.dll assembly and a native
library as well.

We may consider adding support on Posix platforms in the future.
@joshpeterson joshpeterson merged commit 273de1b into unity-master Jun 5, 2019
@joshpeterson joshpeterson deleted the named-pipes-unityaot branch June 5, 2019 18:49
joshpeterson pushed a commit that referenced this pull request Apr 29, 2022
In #1192 we added support
for named pipes on Windows previously. This support failed to work with
the unityaot-win32 profile after the most recent Mono upgrade.

With this change, we will also add tests to IL2CPP to ensure that this
does not break again.
achavakula-rythmos pushed a commit that referenced this pull request May 11, 2022
In #1192 we added support
for named pipes on Windows previously. This support failed to work with
the unityaot-win32 profile after the most recent Mono upgrade.

With this change, we will also add tests to IL2CPP to ensure that this
does not break again.
achavakula-rythmos pushed a commit that referenced this pull request May 11, 2022
In #1192 we added support
for named pipes on Windows previously. This support failed to work with
the unityaot-win32 profile after the most recent Mono upgrade.

With this change, we will also add tests to IL2CPP to ensure that this
does not break again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants