Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put dummy types used in ProcessImportedType in the proper namespace #1197

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

joshpeterson
Copy link

These dummy types were added in 0e66d19
so that the ProcessImportedType method could be added to the
IDataContractSurrogate interface properly. However, the types were not
put in the proper namespace.

Recent changes to the profile stubber to handle overloaded methods
correctly caused an additional ProcessImportedType method to be
incorrectly stubbed in. This change allows the profile stubber to
correctly notice that this method exists, and not stubbing is done.

These dummy types were added in 0e66d19
so that the `ProcessImportedType` method could be added to the
`IDataContractSurrogate` interface properly. However, the types were not
put in the proper namespace.

Recent changes to the profile stubber to handle overloaded methods
correctly caused an additional `ProcessImportedType` method to be
incorrectly stubbed in. This change allows the profile stubber to
correctly notice that this method exists, and not stubbing is done.
@joshpeterson joshpeterson merged commit fbed6eb into unity-master Jun 21, 2019
@joshpeterson joshpeterson deleted the fix-add-mising-codedom-unityaot branch June 21, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant