Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the empty file inode on macOS and FAT32 #1200

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

joshpeterson
Copy link

On macOS and FAT32 partitions, we will sometimes get this inode value
for more than one file. It means the file is empty. When this happens,
the hash table of file shares becomes corrupt, since more then one file
has the same inode. Instead, let's assume it is always fine to share
empty files. (Unity case 950616).

This change was not applied to new Mono, originally I just applied it to old Mono. Once we switch to using new Mono to run tools (e.g. UnityLinker) by default, the problem occurred again. So this PR cherry-picks the change to the new Mono branch, and corrects Unity case 1166108.

Release notes:

UnityLinker: Allow UnityLinker to run properly on FAT32 partitions on macOS. (case 1166108).

I'll back port this change to 2018.4, 2019.1, and 2019.2.

On macOS and FAT32 partitions, we will sometimes get this inode value
for more than one file. It means the file is empty.  When this happens,
the hash table of file shares becomes corrupt, since more then one file
has the same inode. Instead, let's assume it is always fine to share
empty files. (Unity case 950616).
@joshpeterson joshpeterson requested a review from joncham July 8, 2019 15:00
@joshpeterson joshpeterson merged commit cded925 into unity-master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants