Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ETW in Mono mscorlib #1207

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Fix ETW in Mono mscorlib #1207

merged 3 commits into from
Jul 23, 2019

Conversation

TautvydasZilys
Copy link

@TautvydasZilys TautvydasZilys commented Jul 13, 2019

This PR contains code changes for mscorlib that address https://fogbugz.unity3d.com/f/cases/1084396/.

Most of the changes involved changing to using ReferenceSource code instead of Mono's stubs. There were 2 files I needed to copy from CoreFX as they did not exist in our Mono repository.

I'm going to backport this to 2018.4 as many people have been complaining about this lately, especially those who migrated to IL2CPP from .NET scripting backend and had libraries they were using broken.

Release notes:

  • Scripting: fixed logging ETW events from the editor and players (case 1084396).

Copy link
Member

@joncham joncham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kicked off pipeline to rerun. If things are green we are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants