Mono debugger agent memory leak fix, case 1170031 #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create_event_list() in the debugger agent was sending in a pointer for a source file but then never using or freeing it. If we just send in a NULL, the memory won't be allocated.
ghost
requested review from
ghost
self-assigned this
joshpeterson
approved these changes
Aug 1, 2019
|
Is the IL2CPP debugger subject to the same issue? |
joncham
approved these changes
Aug 1, 2019
|
@brianradunity any chance you could upstream this great find? |
|
@brianradunity strike that, I'll submit a PR upstream. |
|
Ok, I was going to check out upstream and see if it still had the same problem. Thanks for beating me to it ;) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_event_list() in the debugger agent was sending in a pointer for a
source file but then never using or freeing it. If we just send in a
NULL, the memory won't be allocated.