Fixing a corner case where an invalid timezone on windows would throw a #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimeZoneNotFoundException. Added a catch to allow mono to try the WinRT fallback which appears to work even when there is an invalid timezone value in the registry.
joncham
approved these changes
Aug 6, 2019
TautvydasZilys
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeZoneNotFoundException. Added a catch to allow mono to try the WinRT
fallback which appears to work even when there is an invalid timezone
value in the registry.
Fixes: 1169719
Release note:
Fixed bug where editor would fail to load correctly when an invalid or missing timezone was set in the windows registry.