Add a new API to generate a Unity-like callstack into a memory buffer #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joncham
reviewed
Feb 19, 2020
| QuickDumpUserData *ud = (QuickDumpUserData *)data; | ||
|
|
||
| if (managed && method) { | ||
| char *method_name = mono_method_full_name (method, TRUE); |
There was a problem hiding this comment.
Note to myself, we should provide a no-alloc or temp alloc version of this and similar functions.
deplinenoise
force-pushed
the
quick-unity-callstack
branch
from
7a66b4e
to
2b4b06b
Compare
joncham
reviewed
Feb 20, 2020
joncham
approved these changes
Feb 20, 2020
UnityAlex
pushed a commit
that referenced
this pull request
Mar 27, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Mar 31, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Apr 13, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Apr 21, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Apr 28, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
May 5, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
May 15, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
May 21, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Jun 10, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Jul 1, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Jul 17, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Jul 31, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Aug 14, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Sep 24, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Oct 30, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Nov 13, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Dec 22, 2020
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Jan 29, 2021
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Feb 5, 2021
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Feb 12, 2021
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Feb 22, 2021
…#1256) * Add a new API to generate a callstack into a memory buffer
UnityAlex
pushed a commit
that referenced
this pull request
Mar 16, 2021
…#1256) * Add a new API to generate a callstack into a memory buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this is to reduce GC pressure when logging a lot in the Unity editor by doing the string formatting in native code directly from Mono.