[IO] Remove read-only logic in mono_w32_get_disk_free_space (#17177) #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings us in line with GetDiskFreeSpaceExW on Windows as well as .NET Core.
|
|
|
Does this fix a specific bug that we have? If so do you have a # handy? |
ok, fixed the PR description Alex. I still have to actually test this, but wanted to get code review underway. |
UnityAlex
approved these changes
Mar 4, 2020
joncham
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unity: case 1221933- Fixes Catalina OSX returning 0 for disk space on read only drives.
Cherry-picked from upstream, fixes mono returning 0 on drives marked as read only. This turned out to be a bigger problem on Catalina than other systems.
Alex tested for me on his Catalina macbook
output before fix
Volume: / -- Available space: 0 bytes
output after fix
Volume: / -- Available space: 51340992921