Optimize Enum.HasFlags (). #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the the upstream changes are applied correctly. Can you add release notes to the PR? Should we back port this? |
joshpeterson
approved these changes
Mar 11, 2020
douglas-piconi
approved these changes
Mar 11, 2020
Manually applied cherry-pick of mono#8428 Unity: Avoid allocation in Enum.HasFlags (case 1211643) * [jit] Decompose some CEE_BOX opcodes later to allow more optimizations. Optimize a code sequence emitted for Enum.HasFlag () by newer csc versions. Also mark the temporary bblocks used by decompose_vtypes () as out-of-line if the bblock under processing is out-of-line. Mark the domainvar as volatile to avoid optimizing it away since references to it can now be generated later from the decomposition of OP_BOX. * [jit] Check that the enum types are the same. * [jit] Fix support for generic enums. * [jit] Disable the optimization with 64 bit enums on 32 bit platforms.
joncham
force-pushed
the
unity-master-fix-1211643
branch
from
b72d409
to
40453e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually applied cherry-pick of mono#8428
Unity:
Release Notes:
Fixed case 1211643:
Scripting: Avoid allocation in Enum.HasFlags.
Backporting:
2020.1, 2019.4, and perhaps 2018.4
Optimize a code sequence emitted for Enum.HasFlag () by newer csc versions.
Also mark the temporary bblocks used by decompose_vtypes () as out-of-line if
the bblock under processing is out-of-line. Mark the domainvar as volatile to avoid
optimizing it away since references to it can now be generated later from the
decomposition of OP_BOX.
[jit] Check that the enum types are the same.
[jit] Fix support for generic enums.
[jit] Disable the optimization with 64 bit enums on 32 bit platforms.