[debugger] Fix NOT_IMPLEMENTED while debugging. (#19248) #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the behavior on debugger-agent, if we can't parse the new behavior is to return invalid_argument and not assert and stop debugging - Changed the mono_domain_set_fast before return from assembly_commands. - Add error message when return INVALID_ARGUMENT Fixes mono#19146
|
FYI we're fixing the VSTU side of the issue in Visual Studio 2019 16.6. |
|
Can we make this change in the IL2CPP debugger code as well? |
Yep I can bring it over to there too. |
joncham
reviewed
Mar 23, 2020
| ReadInt (); // id | ||
| ReadByte (); // flags | ||
| ErrorCode = ReadShort (); | ||
| if (ErrorCode == (int)Mono.Debugger.Soft.ErrorCode.INVALID_ARGUMENT && len > offset) | ||
| ErrorMsg = ReadString (); |
There was a problem hiding this comment.
Is there a protocol bump for this?
There was a problem hiding this comment.
There was not in the PR upstream: mono#19248
I can ask there.
There was a problem hiding this comment.
Looks like the answer is "No, but yes."
joncham
approved these changes
Mar 24, 2020
|
@joncham you're going to have to merge this one because of the CLA bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mono#19146
Fixes case 1197204