Fix abort behavior on Windows #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We statically link the C runtime on Windows and abort handlers are part of the C runtime. This means that Unity's abort handler is not connected to the C runtime in Mono, and when an abort happens we get the default behavior instead of proper chaining/handling to our bug reporter. RaiseException and SEH is process wide. Use RaiseException to force crash instead of abort.
UnityAlex
approved these changes
Apr 6, 2020
joshpeterson
approved these changes
Apr 6, 2020
TautvydasZilys
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We statically link the C runtime on Windows and abort handlers are part of the C runtime. This means that Unity's abort handler is not connected to the C runtime in Mono, and when an abort happens we get the default behavior instead of proper chaining/handling to our bug reporter.
RaiseException and SEH is process wide. Use RaiseException to force crash instead of abort.
Release Notes:
Improved
Scripting: Invoke Unity crash handler when internal abort in Mono is triggered on Windows.
Backporting:
We should backport to all LTS releases for new version of Unity.