X509ChainImplUnityTls reports status now #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Fogbugz ticket 1261388. Impl sticks close to current Mono Btls implementation on _master_ - the implementation on our fork has the same issues as prior to this fix and throws NotImplementedException
UnityAlex
approved these changes
Jul 14, 2020
bitter
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Fogbugz ticket 1261388.
Impl sticks close to current Mono Btls implementation on master - the implementation on our fork has the same issues as prior to this fix and throws
NotImplementedException. For compatibility with upcoming mono update I used a method(-name) that is going to be abstract in theX509ChainImplbaseclass :).Needs to be backported to 2020.1 (according to fogbugz ticket prior to that we didn't have that issue - I vaguely remember that we didn't backport the custom unitytls certificate impl)
As always with these, I extended the playmode tests in Unity to include this:
https://github.cds.internal.unity3d.com/unity/unity/commit/47271815fbefdb7f1520e423fe70db8767781286
(this one sadly needs manual activation and doesn't run on CI right now because it accesses external servers)