Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing more default interface problems (case 1365974) #1551

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Fixing more default interface problems (case 1365974) #1551

merged 4 commits into from
Feb 9, 2022

Commits on Feb 3, 2022

  1. Fix crash in common_call_trampoline due to inconsistent rgctx mode (m… 

    …ono#21250)
    @bholmes
    bholmes committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    7bb0df3 View commit details
    Browse the repository at this point in the history

  2. [mini] Don't add unbox tramopline on generic DIM calls (mono#21208) 

    Don't unbox a valuetype `this` if the generic method is a DIM

Fixes dotnet/runtime#58394

Co-authored-by: lambdageek <[email protected]>
    @bholmes @lambdageek
    bholmes and lambdageek committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    f3e648c View commit details
    Browse the repository at this point in the history

  3. [mono] Fix StackTrace from a dim and Vtable offsets for static interf… 

    …ace method

- Fix StackTrace when called from a DIM.
- Fix the other test case that was added for @bholmes, and this case when the method `TestMethod5` was being called it was executing `TestMethod10`, and this was fixed skipping static interface methods when was calculating vtable offsets.

The fix was completely done by @vargaz, I just opened the PR.
Thanks @vargaz .

Fix dotnet/runtime#60486
    @bholmes
    bholmes committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    f711ebd View commit details
    Browse the repository at this point in the history

  4. mono_get_generic_info_from_stack_frame fix for default interface methods 

    The context is a MonoMethodRuntimeGenericContext when the method is a
default interface method.

Related to dotnet/runtime#62334
    @bholmes
    bholmes committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    05d4377 View commit details
    Browse the repository at this point in the history