2022.1 : Fixing more default interface problems (case 1365974) #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't unbox a valuetype `this` if the generic method is a DIM Fixes dotnet/runtime#58394 Co-authored-by: lambdageek <[email protected]>
…ace method - Fix StackTrace when called from a DIM. - Fix the other test case that was added for @bholmes, and this case when the method `TestMethod5` was being called it was executing `TestMethod10`, and this was fixed skipping static interface methods when was calculating vtable offsets. The fix was completely done by @vargaz, I just opened the PR. Thanks @vargaz . Fix dotnet/runtime#60486
The context is a MonoMethodRuntimeGenericContext when the method is a default interface method. Related to dotnet/runtime#62334
schoudhary-rythmos
changed the title
jhcdunity3d
approved these changes
Mar 4, 2022
bholmes
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several cherry-picks for default interface methods....
Fix crash in common_call_trampoline due to inconsistent rgctx mode mono#21250
[mini] Don't add unbox tramopline on generic DIM calls (mono#21208)
Don't unbox a valuetype this if the generic method is a DIM
Fixes dotnet/runtime#58394
[mono] Fix StackTrace from a dim and Vtable offsets for static interf…
…ace method
Fix StackTrace when called from a DIM.
Fix the other test case that was added for @bholmes, and this case when the method TestMethod5 was being called it was executing TestMethod10, and this was fixed skipping static interface methods when was calculating vtable offsets.
Reviewers: please consider these questions as well! ❤️
Release notes
Fixed case 1365974 @schoudhary-rythmos :
Mono: Fix generic default interface method crash with Environment.StackTrace.
Comments to reviewers
Cherry picked changes from the Trunk PR : #1551
The cherry pick was 100% clean.