feat(settings): made it scrollable #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frigyes06
previously approved these changes
Dec 24, 2023
|
Do you want to fix the font sizes in a different PR? |
Yep because it may need other adjustments |
|
As you mentioned, the code currently has So we'd use 14, 20, 24 |
Frigyes06
previously approved these changes
Dec 24, 2023
adhirajsinghchauhan
force-pushed
the
feature/scrollable-settings
branch
from
395cd91
to
2acb494
Compare
Frigyes06
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116 and #45.
Continuing from #97 (comment).
When content exceeds window height:
When content fits within window:
