Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): standardized font size and layout fixes #118

Merged

Conversation

Frigyes06
Copy link
Member

@Frigyes06 Frigyes06 commented Dec 24, 2023

Fixes #115

@Frigyes06 Frigyes06 marked this pull request as draft December 24, 2023 21:57
src/gui/views/list.rs Outdated Show resolved Hide resolved
src/gui/views/list.rs Outdated Show resolved Hide resolved
@Frigyes06 Frigyes06 marked this pull request as ready for review December 24, 2023 22:13
@Frigyes06
Copy link
Member Author

image
These texts get a bit cut off

@adhirajsinghchauhan adhirajsinghchauhan added enhancement New feature or request UI Related to the UI labels Dec 24, 2023
@adhirajsinghchauhan adhirajsinghchauhan merged commit e049bc6 into main Dec 24, 2023
16 checks passed
@adhirajsinghchauhan adhirajsinghchauhan deleted the feature/standardized-font-size-and-layout-fixes branch December 24, 2023 22:17
@AnonymousWP AnonymousWP changed the title Feature/standardized font size and layout fixes feat: standardized font size and layout fixes Feb 6, 2024
@Frigyes06 Frigyes06 changed the title feat: standardized font size and layout fixes feat(ui): standardized font size and layout fixes Feb 6, 2024
@shapeshifterincontext
Copy link

Can we go back to the font and size used in this. V1.0.3 is not 'bad eyesight' friendly. The letters in each word are squashed together.

@Rudxain
Copy link
Member

Rudxain commented Sep 5, 2024

Can we go back to the font and size used in this.

I agree, the text is too small

@adhirajsinghchauhan
Copy link
Contributor

Could you please post screenshots? We didn't change text sizes again after this PR.

@Rudxain
Copy link
Member

Rudxain commented Sep 5, 2024

cargo run on main:
Screenshot  2024-09-05 03-14-54

  • Linux 6.10
  • Debian 13 "Trixie"
  • GNOME 46
  • Wayland 1.23 (+ Mutter)
  • Intel HD Graphics 4000
  • Display resolution = 1366×768 px
  • GNOME display scale = 1x (hidden from GUI, because display is not "hi-DPI")
  • Tweaks "Font" size scale factor = 1.5

@AnonymousWP
Copy link
Member

For me it doesn't look small, neither does the text on your screenshot.

@Rudxain
Copy link
Member

Rudxain commented Sep 5, 2024

The review modal text isn't small, but it is relative to this

Although the main pack list (the one behind the modal) seems even smaller to me

@AnonymousWP
Copy link
Member

The review modal text isn't small, but it is relative to this img

Although the main pack list (the one behind the modal) seems even smaller to me

Your screenshot returns a 404. It's a private user URL.

@Rudxain

This comment was marked as off-topic.

@adhirajsinghchauhan
Copy link
Contributor

404

That's odd 👀😕. It's the same screenshot from here. Both load from my POV

Notice the jwt parameter in that URL, though. It would differ per session, so what works for you won't work for others. Not sure if this token could be used to gain access to your account, but I'd contact GitHub anyway, to scrub your comment.

@Rudxain

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI Related to the UI
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make font sizes uniform
5 participants