fix: allow the app to display logs when launced from the terminal on windows #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavafroth
suggested changes
Feb 10, 2024
There was a problem hiding this comment.
Could you please update your branch with the main branch? Also, you could possibly look into this crate.
|
I'm unable to test this right now due to the lack of a windows machine. |
B0ney
force-pushed
the
fix/show-logs-on-windows
branch
from
806a9e1
to
414f991
Compare
|
Done!
|
|
I can test later today |
lavafroth
approved these changes
Feb 11, 2024
lavafroth
merged commit 2cccec2
into
Universal-Debloater-Alliance:main
2 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #237
While
#![windows_subsystem = "windows"]is fine since we don't want the app to create the terminal on startup, this has the consequence of outright disabling terminal output, even if we launch it from the console.The proposed fix uses
windows-systo attach the process' stout to any available console.Reference: https://learn.microsoft.com/en-us/windows/console/attachconsole
While this introduces a new dependency, since they're raw FFI calls for the windows-api, they should add little to no overhead.