-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): edit checksum artifact paths to allow automatic check #295
fix(ci): edit checksum artifact paths to allow automatic check #295
Conversation
I realized that windows has different line ending from unix systems and that's why I couldn't automatically check it with the instructions from the description. Anyways it doesn't make sense trying to check for windows checksum with the standard ubuntu way. It would be great if someone with windows system could download windows artifacts from my local branch action run and check if it works. |
I thought windows had a similar way to check the checksums such as in UNIX with the commands listed in the description, but I didn't find anything online, and since the checksums match everything is okay. Is there any way to do a test release to see if everything works correctly? I am 99.99% sure that this is going to work, but just to be safe :) |
Not that I know of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes make sense to me. I don't have a way to test them before we release again though.
I don't think there's a way to test this besides merging this and creating a new release with these changes applied. This should work flawlessly IMO |
You can calculate hashes with Windows using PowerShell commands. Is that what you're looking for? Get-FileHash uad-ng-windows.exe |
Nope, I am aware of the fact that you can calculate checksums on windows. We could compare that command to: (on debian-based systems) sha256sum uad-ng-windows.exe I was mostly curious if windows has something similar such as: sha256sum --check uad-ng-windows.exe Which gives you the |
At this point we might as well use `cargo cross` which can be used on a single linux machine to cross compile to multiple platforms. Profit: we have to do the checksum business only once.
|
Nope. You'd need to be far more verbose: (Get-FileHash <file>).Hash -eq (Get-Content <checksum-file>) Which would return |
Well, than from my understanding it seems that windows doesn't really have one standardized way to do this, therefore there are X ways to verify the checksum, and we can have N ways to format I also like an approach of having just binary artifacts and one From my POV there isn't 1 best way to do this - it all depends on which approach the project maintainers like the most. |
Isn't this the best solution then? We need to automate it as much as possible, but why including a tool with the release? Why not just something like what Microsoft does (automatically calculating the hash and users can then compare it the calculation they can perform themselves):
I think users who want to verify the hash can perfectly do that themselves. 🙂 |
Closes #270.
All checksums (except windows) can now be verified using standard way with sha256sum utility:
sha256sum <binary>
sha256sum --check <binary>-checksum
<binary>: OK