Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uad-list): json parsing error #371

Merged
merged 3 commits into from
Mar 23, 2024
Merged

fix(uad-list): json parsing error #371

merged 3 commits into from
Mar 23, 2024

Conversation

edgy-b
Copy link
Contributor

@edgy-b edgy-b commented Mar 23, 2024

  • fixed json file
  • added more verbose explanation where update failed in update.rs file

resolves #370

@edgy-b edgy-b requested a review from AnonymousWP March 23, 2024 10:21
 - remove part of code worked on issue for updating app
@AnonymousWP AnonymousWP added the bug Something isn't working label Mar 23, 2024
@adhirajsinghchauhan
Copy link
Contributor

adhirajsinghchauhan commented Mar 23, 2024

Hmm blame points to #367. We should come up with CI that checks JSON correctness to avoid such situations again. It's a very large file, thus prone to human error every now and then.

@AnonymousWP AnonymousWP merged commit 7750a19 into main Mar 23, 2024
16 checks passed
@AnonymousWP AnonymousWP deleted the bug/uad_list branch March 23, 2024 11:07
@AnonymousWP AnonymousWP changed the title bug(uad-list): json parsing error fix(uad-list): json parsing error Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(scope): UAD stuck in downloading latest UAD-ing lists from GitHub
3 participants