-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: graphically display error when adb command fails #409
Conversation
Could you please include a screenshot for references? Then we can also give feedback about that. |
I've added the screenshot |
I'm busy, so I'll let other devs review this |
Here's the code health analysis summary for commits Analysis Summary
|
09a633a
to
898f815
Compare
I've added a scrollbar to the error text. Should be fine for a merge. |
This can't be merged though due to failing checks. |
That was a comment to keep track of where I was getting stuck. Removed it, thanks for the check.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, please add more comments next time :)
This is more or less scaffold code to display the raw error if an ADB command fails.
Related to #37
Generic
.