Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): run test coverage in CI and upload to DeepSource #416

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

Frigyes06
Copy link
Member

@Frigyes06 Frigyes06 commented Apr 9, 2024

Added a new job to CI which generates and uploads code coverage data to DeepSource automatically.
This will only run when .rs files are changed, so DeepSource will still fail test coverage on PRs not triggering the CI script.
We could extract it to a standalone Action, however I feel that's a waste of GitHub's resources.

Copy link
Contributor

deepsource-io bot commented Apr 9, 2024

Here's the code health analysis summary for commits 75287ba..e955dad. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Frigyes06 Frigyes06 marked this pull request as draft April 9, 2024 20:23
@AnonymousWP AnonymousWP added the enhancement New feature or request label Apr 9, 2024
@Frigyes06 Frigyes06 marked this pull request as ready for review April 9, 2024 20:45
@Frigyes06 Frigyes06 requested a review from a team April 9, 2024 20:45
@Frigyes06
Copy link
Member Author

I need this merged pls

@lavafroth lavafroth merged commit 8df133c into main Apr 13, 2024
2 of 3 checks passed
@Frigyes06 Frigyes06 deleted the feat/upload-test-coverage-to-DeepSouce-in-CI branch April 13, 2024 15:06
@adhirajsinghchauhan
Copy link
Contributor

Would this PR now make it so that the "DeepSource: Test coverage" check will work?

@Frigyes06
Copy link
Member Author

@adhirajsinghchauhan see comments in PR body. It should, when the CI is triggered. Meaning if the CI is not triggered, the test will still fail sadly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants