-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Nix flake #421
feat: add Nix flake #421
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure who's gonna maintain this in case there are errors/updates etc.
IIRC, libexpat is needed for GTK.
|
I'll be investigating this X11 issue.
|
@lavafroth Any updates on this? |
Hi, the dependencies in this flake are the ones being used in the official nixpkgs ever since I updated the package derivation. You can test it out in a NixOS or Nix environment either using the flake or the official package (I'm maintaining the nixpkg for now). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK the exact semantics of the file, because I haven't read the docs. But LGTM anyways 👍
Although, I'm unsure if I should approve it. I don't feel qualified for this (yet)
This comment was marked as off-topic.
This comment was marked as off-topic.
No, just go to Reviewers and scroll down until you see the Developers team. |
Seems like I'm the only dev here who daily drives NixOS. Not sure who else can test this out. |
Maybe someone from #43 ? |
This comment was marked as duplicate.
This comment was marked as duplicate.
precisely
…-------- Original Message --------
On 9/14/24 17:52, Ricardo Fernández Serrata wrote:
If I understood correctly, it should be possible to test by installing the nix package-manager on any Unix-like OS
—
Reply to this email directly, [view it on GitHub](#421 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AZUKSCABZK5FL24NWD7YXVLZWQS65AVCNFSM6AAAAABGFDGGPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE3TENBSHA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
The flake only has a devshell. There's no output package. You should try running nix develop
…-------- Original Message --------
On 9/14/24 23:09, Anonymoussaurus wrote:
@AnonymousWP requested changes on this pull request.
---------------------------------------------------------------
On [flake.nix](#421 (comment)):
Seems like it doesn't support AlmaLinux:
nix build
error: flake 'git+file:///home/anonymoussaurus/universal-android-debloater-next-generation' does not provide attribute 'packages.x86_64-linux.default' or 'defaultPackage.x86_64-linux'
Maybe we should add something like
systems = [ "x86_64-linux" "aarch64-linux" "x86_64-darwin" ];?
—
Reply to this email directly, [view it on GitHub](#421 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AZUKSCGIQYCMA5DYOELKLFLZWRYGFAVCNFSM6AAAAABGFDGGPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMBUHEYDKMBYHE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works. Do we need to write documentation for this before merging or you think it's not necessary?
We can't write tests for a flake. Thanks again for testing it out! 😃
…-------- Original Message --------
On 9/15/24 19:50, Anonymoussaurus wrote:
@AnonymousWP approved this pull request.
Tested and works. Do we need to write documentation for this before merging or you think it's not necessary?
—
Reply to this email directly, [view it on GitHub](#421 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AZUKSCD7YZWLKKXNC7LT3DTZWWJT5AVCNFSM6AAAAABGFDGGPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMBVGM3TCMBVGE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Alright, and thank you for following up on several PRs and issues. 😄 |
Also if you could add the `nix develop` command in the readme for nix users, that'd be great!
…-------- Original Message --------
On 9/15/24 19:53, lavafroth wrote:
We can't write tests for a flake. Thanks again for testing it out! 😃
-------- Original Message --------
On 9/15/24 19:50, Anonymoussaurus wrote:
> @AnonymousWP approved this pull request.
>
> Tested and works. Do we need to write documentation for this before merging or you think it's not necessary?
>
> —
> Reply to this email directly, [view it on GitHub](#421 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AZUKSCD7YZWLKKXNC7LT3DTZWWJT5AVCNFSM6AAAAABGFDGGPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMBVGM3TCMBVGE).
> You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Related to #43