Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Nix flake #421

Merged
merged 9 commits into from
Sep 15, 2024
Merged

feat: add Nix flake #421

merged 9 commits into from
Sep 15, 2024

Conversation

lavafroth
Copy link
Contributor

Related to #43

  • Adds a flake.nix file which describes all the dependencies and outputs a dev shell where Nix users can build uadng.
  • Adds a flake.lock file to pin the dependencies to tested versions.

Copy link
Contributor

deepsource-io bot commented Apr 13, 2024

Here's the code health analysis summary for commits 2a1ebba..4f4359a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@AnonymousWP AnonymousWP changed the title Add Nix flake feat: add Nix flake Apr 13, 2024
@AnonymousWP AnonymousWP added enhancement New feature or request dependencies Pull requests that update a dependency file labels Apr 13, 2024
@AnonymousWP AnonymousWP requested a review from a team April 13, 2024 11:45
@adhirajsinghchauhan adhirajsinghchauhan added the help wanted Extra attention is needed label Apr 14, 2024
Copy link
Contributor

@edgy-b edgy-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure who's gonna maintain this in case there are errors/updates etc.

flake.nix Outdated Show resolved Hide resolved
flake.nix Show resolved Hide resolved
@lavafroth
Copy link
Contributor Author

lavafroth commented May 1, 2024 via email

@lavafroth
Copy link
Contributor Author

lavafroth commented May 1, 2024 via email

@AnonymousWP
Copy link
Member

@lavafroth Any updates on this?

@lavafroth
Copy link
Contributor Author

Hi, the dependencies in this flake are the ones being used in the official nixpkgs ever since I updated the package derivation. You can test it out in a NixOS or Nix environment either using the flake or the official package (I'm maintaining the nixpkg for now).

@AnonymousWP AnonymousWP requested a review from a team September 13, 2024 06:38
Copy link
Member

@Rudxain Rudxain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK the exact semantics of the file, because I haven't read the docs. But LGTM anyways 👍

Although, I'm unsure if I should approve it. I don't feel qualified for this (yet)

@Rudxain

This comment was marked as off-topic.

@AnonymousWP
Copy link
Member

Wait... did GH just remove the review-request for all devs?

No, just go to Reviewers and scroll down until you see the Developers team.

@Rudxain Rudxain requested a review from a team September 13, 2024 10:50
@lavafroth
Copy link
Contributor Author

Seems like I'm the only dev here who daily drives NixOS. Not sure who else can test this out.

@AnonymousWP
Copy link
Member

Maybe someone from #43 ?

@Rudxain

This comment was marked as duplicate.

@lavafroth
Copy link
Contributor Author

lavafroth commented Sep 14, 2024 via email

flake.nix Show resolved Hide resolved
@lavafroth
Copy link
Contributor Author

lavafroth commented Sep 15, 2024 via email

Copy link
Member

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Do we need to write documentation for this before merging or you think it's not necessary?

@lavafroth
Copy link
Contributor Author

lavafroth commented Sep 15, 2024 via email

@AnonymousWP
Copy link
Member

We can't write tests for a flake. Thanks again for testing it out! 😃

-------- Original Message --------
On 9/15/24 19:50, Anonymoussaurus wrote: @AnonymousWP approved this pull request. Tested and works. Do we need to write documentation for this before merging or you think it's not necessary? — Reply to this email directly, [view it on GitHub](#421 (review)), or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

Alright, and thank you for following up on several PRs and issues. 😄

@AnonymousWP AnonymousWP merged commit a0b0d6e into main Sep 15, 2024
2 of 3 checks passed
@AnonymousWP AnonymousWP deleted the nix-flake branch September 15, 2024 14:24
@lavafroth
Copy link
Contributor Author

lavafroth commented Sep 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants