-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backup): re-add export selection to text file #435
Conversation
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
- added back possibility to export current selection to txt file - on successful export show modal
.padding(10) | ||
.style(style::Container::Frame); | ||
|
||
return Modal::new(content.padding(10), ctn) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might not need the explicit return here. Just a nit though.
@@ -116,6 +119,7 @@ impl List { | |||
Message::ModalHide => { | |||
self.selection_modal = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have so many modals, we might be better off with creating some sort of enum like self.focused_modal = Modal::Selection
and then match
upon that. Anyways, you don't have to implement it here. Let's do that in a separate commit / PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise. Maybe add some documentations to keep deepsource happy.
You're right. Will do that in core/DRY branch, since I already started on cleaning and tidying the code. |
added back possibility to export current selection to txt file
on successful export show modal
Resolves #300