Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(ui): visual bugs in selection review #452

Merged
merged 1 commit into from
May 8, 2024
Merged

bug(ui): visual bugs in selection review #452

merged 1 commit into from
May 8, 2024

Conversation

edgy-b
Copy link
Contributor

@edgy-b edgy-b commented May 6, 2024 •
edited
Loading

  • increased width of modal

  • adjusted some column sizes

image

Resolves #121

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented May 6, 2024 •
edited
Loading

Here's the code health analysis summary for commits 189cf4a..65e78c0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ Success
❗ 1 occurence introduced
🎯 1 occurence resolved
View Check ↗

Code Coverage Report

MetricAggregateRust
Branch Coverage100%0%
Composite Coverage1.8%1.8%
Line Coverage1.8%1.8%
New Branch Coverage100%100%
New Composite Coverage0%0%
New Line Coverage0%0%
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@AnonymousWP AnonymousWP added the bug Something isn't working label May 6, 2024
@edgy-b
bug(ui): visual bugs in selection review
65e78c0 
 - increased width of modal

 - adjusted some column sizes
@edgy-b edgy-b requested a review from a team May 7, 2024 11:35
adhirajsinghchauhan
adhirajsinghchauhan approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@adhirajsinghchauhan adhirajsinghchauhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should refactor to use iced_table, but for now it's good.

From https://github.com/tarkah/iced_table:
demo

@adhirajsinghchauhan adhirajsinghchauhan merged commit 622b559 into main May 8, 2024
21 checks passed
@adhirajsinghchauhan adhirajsinghchauhan deleted the bug/ui-visual-bugs branch May 8, 2024 05:32
@AnonymousWP AnonymousWP mentioned this pull request May 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhirajsinghchauhan adhirajsinghchauhan adhirajsinghchauhan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visual bugs in selection review
3 participants
@edgy-b @adhirajsinghchauhan @AnonymousWP