-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theming): add icon to Windows executable #470
feat(theming): add icon to Windows executable #470
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Thanks for this! Related opinion: #197 (comment) Since you're on Windows, could you post comparison sizes for both the debug & release builds? |
@adhirajsinghchauhan The screenshot was from a VM. The executables were built using
Not sure about |
fd50320
to
9cc1799
Compare
Something to note is that the icon size would be about 130KB instead of 400KB, if we were to reduce the max icon size from 256px to 128px. If you're concerned about size that is. Also, here are the file sizes with
|
59a6605
into
Universal-Debloater-Alliance:main
Fixes #462
embed-resource
.The icon is just the
logo-dark.png
with a dark background and slightly curved borders. We should go with it unless we have a better design.