-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg(sony): add packages of Android TV #498
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
About the Sony's browser. I'm not sure if the removal level should be expert or recommended. What do you say? |
Also there are way more apps on Sony TV which are unlisted but this is the visible bloatware on app drawer page. I'm not really confident on messing with the other packages as this is my only TV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. 🙂 A few suggestions.
Are you able to set another browser as default so that it opens with another browser instead of Sony's? |
There are no default apps on android TV. You are able to download other browsers and the webview is still there if necessary. Answering your question if you uninstall the sony's browser then the other one is able open websites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements
I see, but then you'll have to install an alternative browser first. I'll suggest adding a note, sec.
Please make the changes by committing; clicking 'resolve' doesn't make any changes on its own. It's just marking it as solved. |
Bear with me. It's my first pull request I made some changes can you do the review again |
It's a good first step. You applied my suggestion for my first comment (not exactly though), but not the other comments: https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/pull/498/files/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I get what to do now just do another review so i can do it properly this time. Sorry for the hassle |
You're not supposed to review your own changes. Do you use an IDE or do you use the web editor of GitHub? In case of the latter, just make the changes how you did when you opened this pull request initially. |
Done. |
That should do it 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's all good now.
1065084
into
Universal-Debloater-Alliance:main
No description provided.