Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg(sony): add packages of Android TV #498

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

M0-7
Copy link
Contributor

@M0-7 M0-7 commented Jun 3, 2024

No description provided.

Copy link
Contributor

deepsource-io bot commented Jun 3, 2024

Here's the code health analysis summary for commits c814057..4d8c0e0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@M0-7
Copy link
Contributor Author

M0-7 commented Jun 3, 2024

About the Sony's browser. I'm not sure if the removal level should be expert or recommended. What do you say?

@AnonymousWP AnonymousWP changed the title Add some unlisted Sony and other packages pkg(sony): add packages Jun 3, 2024
@AnonymousWP AnonymousWP added the package::addition Adding new apps to the debloat list label Jun 3, 2024
@M0-7
Copy link
Contributor Author

M0-7 commented Jun 3, 2024

Also there are way more apps on Sony TV which are unlisted but this is the visible bloatware on app drawer page. I'm not really confident on messing with the other packages as this is my only TV

Copy link
Member

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. 🙂 A few suggestions.

resources/assets/uad_lists.json Show resolved Hide resolved
resources/assets/uad_lists.json Show resolved Hide resolved
resources/assets/uad_lists.json Show resolved Hide resolved
resources/assets/uad_lists.json Show resolved Hide resolved
@AnonymousWP AnonymousWP changed the title pkg(sony): add packages pkg(sony): add packages on Android TV Jun 3, 2024
@AnonymousWP
Copy link
Member

About the Sony's browser. I'm not sure if the removal level should be expert or recommended. What do you say?

Are you able to set another browser as default so that it opens with another browser instead of Sony's?

@M0-7
Copy link
Contributor Author

M0-7 commented Jun 3, 2024

There are no default apps on android TV. You are able to download other browsers and the webview is still there if necessary. Answering your question if you uninstall the sony's browser then the other one is able open websites

Copy link
Contributor Author

@M0-7 M0-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements

@AnonymousWP
Copy link
Member

There are no default apps on android TV. You are able to download other browsers and the webview is still there if necessary. Answering your question if you uninstall the sony's browser then the other one is able open websites

I see, but then you'll have to install an alternative browser first. I'll suggest adding a note, sec.

Good improvements

Please make the changes by committing; clicking 'resolve' doesn't make any changes on its own. It's just marking it as solved.

@M0-7
Copy link
Contributor Author

M0-7 commented Jun 3, 2024

Bear with me. It's my first pull request how do i do that

I made some changes can you do the review again

@M0-7 M0-7 requested a review from AnonymousWP June 3, 2024 15:31
@AnonymousWP
Copy link
Member

Bear with me. It's my first pull request how do i do that

I made some changes can you do the review again

It's a good first step. You applied my suggestion for my first comment (not exactly though), but not the other comments: https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/pull/498/files/

Copy link
Contributor Author

@M0-7 M0-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@M0-7
Copy link
Contributor Author

M0-7 commented Jun 3, 2024

I get what to do now just do another review so i can do it properly this time. Sorry for the hassle

@AnonymousWP
Copy link
Member

You're not supposed to review your own changes. Do you use an IDE or do you use the web editor of GitHub? In case of the latter, just make the changes how you did when you opened this pull request initially.

M0-7

This comment was marked as resolved.

@M0-7
Copy link
Contributor Author

M0-7 commented Jun 3, 2024

Done.

@AnonymousWP
Copy link
Member

AnonymousWP commented Jun 3, 2024

There are two more suggestions you didn't do yet. 🙂
image

@M0-7
Copy link
Contributor Author

M0-7 commented Jun 3, 2024

That should do it 🤞

Copy link
Member

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's all good now.

resources/assets/uad_lists.json Show resolved Hide resolved
resources/assets/uad_lists.json Show resolved Hide resolved
@AnonymousWP AnonymousWP changed the title pkg(sony): add packages on Android TV pkg(sony): add packages of Android TV Jun 3, 2024
@AnonymousWP AnonymousWP merged commit 1065084 into Universal-Debloater-Alliance:main Jun 3, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package::addition Adding new apps to the debloat list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants