-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci): add new unit tests #654
base: main
Are you sure you want to change the base?
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Why is macos not playing nice |
[Safari flashbacks 😭] In all seriousness, I assume it's a lack of file-system permissions |
Thanks to everyone for your patience. I can finally review now |
use std::path::Path; | ||
|
||
// create a clean default config file for testing | ||
fn create_default_config_file() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could expose this, as part of Config
. But this is fine, for now
fn test_palette() { | ||
let palette = Theme::default().palette(); | ||
|
||
assert_ne!(palette.base.background, palette.base.foreground); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely add doc-comments explaining the intended usage of every base
, normal
, and bright
colors (on another PR). I thought foreground
was the text color 😅.
I had to search all references and check the Theme
palettes to get a vague idea of which color corresponds to what 💀
FG & BG can be similar colors. My bad 😅
Created a few simple tests