Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): add new unit tests #654

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

build(ci): add new unit tests #654

wants to merge 8 commits into from

Conversation

Frigyes06
Copy link
Member

Created a few simple tests

Frigyes06 and others added 2 commits September 25, 2024 12:23
@Frigyes06
build(test): added some more unit tests
146a159
@deepsource-autofix
style: format code with Rustfmt
7603c0f 
This commit fixes the style issues introduced in 146a159 according to the output
from Rustfmt.

Details: #654
@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Sep 25, 2024 •
edited
Loading

Here's the code health analysis summary for commits 3727469..70d278d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust❌ Failure
❗ 2 occurences introduced
View Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@AnonymousWP AnonymousWP changed the title build(ci): Create new unit tests build(ci): add new unit tests Sep 25, 2024
@AnonymousWP AnonymousWP added the testing Validation and tests label Sep 25, 2024
@AnonymousWP AnonymousWP requested a review from a team September 25, 2024 19:28
@Frigyes06
Copy link
Member Author

Why is macos not playing nice

@Rudxain
Copy link
Member

Rudxain commented Sep 26, 2024

macos not playing nice

[Safari flashbacks 😭]

In all seriousness, I assume it's a lack of file-system permissions

Rudxain
Rudxain requested changes Sep 26, 2024
View reviewed changes
src/gui/style.rs Outdated Show resolved Hide resolved
@Rudxain Rudxain requested a review from a team October 10, 2024 05:44
@Rudxain
Copy link
Member

Rudxain commented Oct 14, 2024

Thanks to everyone for your patience. I can finally review now

Rudxain
Rudxain reviewed Oct 14, 2024
View reviewed changes
src/core/config.rs
use std::path::Path;

// create a clean default config file for testing
fn create_default_config_file() {
Copy link
Member

@Rudxain Rudxain Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could expose this, as part of Config. But this is fine, for now

Rudxain
Rudxain reviewed Oct 14, 2024
View reviewed changes
src/gui/style.rs
fn test_palette() {
let palette = Theme::default().palette();

assert_ne!(palette.base.background, palette.base.foreground);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely add doc-comments explaining the intended usage of every base, normal, and bright colors (on another PR). I thought foreground was the text color 😅.

I had to search all references and check the Theme palettes to get a vague idea of which color corresponds to what 💀

FG & BG can be similar colors. My bad 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rudxain Rudxain Rudxain approved these changes

Assignees
No one assigned
Labels
testing Validation and tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Frigyes06 @Rudxain @AnonymousWP