Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg(google): change overlay removals to expert #674

Merged
merged 2 commits into from
Oct 20, 2024
Merged

pkg(google): change overlay removals to expert #674

merged 2 commits into from
Oct 20, 2024

Conversation

AnonymousWP
Copy link
Member

No description provided.

@AnonymousWP AnonymousWP added the package::documentation Improve a description/recommendation label Oct 5, 2024
@AnonymousWP AnonymousWP linked an issue Oct 5, 2024 that may be closed by this pull request
Recommended apps breaks System Navigation #571
Closed
3 tasks
@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Oct 5, 2024 •
edited
Loading

Here's the code health analysis summary for commits 56aedda..2e0a87a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Rudxain
Copy link
Member

Rudxain commented Oct 14, 2024

Possibly off-topic: I've noticed that many neighboring descriptions misuse parentheses, such as the description for com.google.android.overlay.gmsconfig.gsa. Usually, these parens are used as if they were quotes. I would prefer if they were backticks ("`").

Rudxain
Rudxain previously approved these changes Oct 14, 2024
View reviewed changes
@Rudxain Rudxain merged commit 26aee1e into main Oct 20, 2024
20 of 21 checks passed
@Rudxain Rudxain deleted the 571-recommended-apps-breaks-system-navigation branch October 20, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rudxain Rudxain Rudxain approved these changes

Assignees
No one assigned
Labels
package::documentation Improve a description/recommendation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recommended apps breaks System Navigation
2 participants
@AnonymousWP @Rudxain