-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg(samsung): change removal of 2 packages #679
base: main
Are you sure you want to change the base?
pkg(samsung): change removal of 2 packages #679
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
@@ -3867,7 +3867,7 @@ | |||
"dependencies": [], | |||
"neededBy": [], | |||
"labels": [], | |||
"removal": "Recommended" | |||
"removal": "Advanced" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"removal": "Advanced" | |
"removal": "Expert" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should start transitioning most of One UI apps to Expert.
Apparently in 6.1.1, even the ones that you can disable on-device are now causing massive battery drain and high temps.
7.0 is looking worse.
I personally do not debloat on Samsung anymore and do not condone debloating 6.1.1 and later.
They also killed components in Knox SDK very recently. Samsung is making a hard push towards anti-debloating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So not even the #670 workaround works? That's rough 😕. Yet another reason to hate Samsung
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't think the Samsung stuff has anything to do with that other GApps stuff.
One UI is super intertwined, e.g. opening the Samsung Account setting will make all sorts of calls to SBrowser, SCloud, SCS, etc and does some serious overheating and battery drain if they're not present.
Smart Suggestions, even when disabled in settings, gets called in almost every setting screen so being in the setting screen is constantly killing your battery. Samsung allows Smart Suggestions app to be disabled on-device on top of disabling the setting... yet this happens when the app is disabled. Even with the option, it's a fake one.
Worst is Diagmonagent, which when disabled, will straight up make thousands of retry calls per second. Only uninstalling or leaving it alone (and letting it log your every action) work here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn, this is some very anti-consumer behaviour from Samsung right there. Do you think we should do this in a single PR? But then we'll have to know from which OneUI version this applies, and on top of that there's the issue where the removal of an app does not have the same effect on OneUI version X as on Y. So how are we going to do that? Change the description? Put it in the Wiki?
Dismissing due to pending/open suggestions.
No description provided.