Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg(boyue): add Boyue packages #699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renanglr
Copy link

This list of applications comes from a Boyue Likebook Mars e-book reader running Android 8.1 (OEM firmware version 3.1.1).

The descriptions should be accurate for all Boyue devices, however they have recently rebranded themselves as "Meebook" and their new devices are using applications which look identical to the ones used in the Boyue devices. I do not know if they changed the application IDs after rebranding.

This list of applications comes from a Boyue Likebook Mars e-book reader
running Android 8.1 (OEM firmware version 3.1.1).

The descriptions should be accurate for all Boyue devices, however they
have recently rebranded themselves as "Meebook" and their new devices
are using applications which look identical to the ones used in the
Boyue devices. I do not know if they changed the application IDs after
rebranding.
Copy link
Contributor

deepsource-io bot commented Oct 25, 2024

Here's the code health analysis summary for commits c3fe1a4..82eaa9c. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

"dependencies": [],
"neededBy": [],
"labels": [],
"removal": "Advanced"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"removal": "Advanced"
"removal": "Expert"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stock launchers are specifically mentioned in the FAQ as apps that should be tagged as Advanced. The app adjustment screen might be important enough to change the classification, but the most important of the features in this screen (A2 refresh mode) can be activated system wide via Quick Settings. As far as I have searched, nobody seems to tweak the other options.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need a change.

Modern Android features are not as independent as they used to be, and too tied together to be removing gallery/launcher/cloud/keyboard/browser/settings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need a change.

As in we may want to change the Wiki or all removals of launchers?

"dependencies": [],
"neededBy": [],
"labels": [],
"removal": "Advanced"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"removal": "Advanced"
"removal": "Expert"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this one. Removing the file manager does not break any important functionality in the device and it can be replaced by another alternative which will not look as nice on e-ink but will have all the same functionality or more. Following the FAQ, it looks like it should be classified as Advanced.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the file manager breaks the functionality that allows you to manage your files. 🤔
Same reason Camera would likely be expert.

@AnonymousWP AnonymousWP added the package::addition Adding new apps to the debloat list label Oct 27, 2024
@AnonymousWP AnonymousWP changed the title pkg(Boyue): Add Boyue applications pkg(boyue): add Boyue packages Oct 27, 2024
Copy link
Member

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes due to pending suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package::addition Adding new apps to the debloat list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants