Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of flat:foreign #459

Closed
nschneid opened this issue Oct 28, 2023 · 1 comment
Closed

Remove use of flat:foreign #459

nschneid opened this issue Oct 28, 2023 · 1 comment

Comments

@nschneid
Copy link
Contributor

Per core group discussion, Foreign=Yes is the recommended way to represent that a word is foreign, so there is no need for the flat:foreign subtype. GUM does not use the subtype. We may as well remove it from EWT.
nschneid added a commit that referenced this issue Oct 28, 2023
@nschneid
flat:foreign->flat (#459), add missing Foreign=Yes, clean up some mis…
a51f542 
…spelled Latin abbreviations and allow the NOUN/FW combination for 'etc.' in neaten.py
@nschneid
Copy link
Contributor Author

I see that, as of UD 2.12, English-ParTUT and English-ESLSpok both used flat:foreign. So I won't remove it now from the English deprels page, but I think it should be considered deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nschneid