Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Add tf_prefix to logger name for hardware interface #691

Closed
firesurfer opened this issue May 25, 2023 · 1 comment
Closed

[Feature] - Add tf_prefix to logger name for hardware interface #691

firesurfer opened this issue May 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@firesurfer
Copy link
Contributor

Currently the logger name for all hardware interface instances (and therefore instances of the UR client library) is the same. Therefore one can not distinguish reported errors.

Given that I am not 100% sure how the UrclLogHandler interacts with the client library I am adding this as a feature request instead of adding a PR.

@fmauch
Copy link
Collaborator

fmauch commented Jun 6, 2023

That's a very good idea. To achieve this, the UrclLogHandler would have to be made aware of the logging prefix and then all logging from the client library should be correctly prefixed.

@fmauch fmauch added the enhancement New feature or request label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants