Introduced tf_prefix into log handler #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@firesurfer thank you for your efforts. In order to speed things up in the future, please consider formatting your code when opening MRs. As far as I can see it right now, there seem to be missing migrations inside the calibration package. |
|
Hi I just found a bit of time to look into this again.
Could you point me out what is missing inside the calibration package. I just took a quick look and couldn't find it EDIT: Nevermind. Found it and fixed it be adding a default argument for the tf_prefix in the register function |
fmauch
approved these changes
Jul 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Introduced tf_prefix into log handler * added default argument to prefix --------- Co-authored-by: Lennart Nachtigall <[email protected]> Co-authored-by: Felix Exner <[email protected]> Co-authored-by: Lennart Nachtigall <[email protected]> (cherry picked from commit d7e0d6d)
|
@Mergifyio backport iron Since #753 isn't merged yet, I'll have to call this manually. |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Introduced tf_prefix into log handler * added default argument to prefix --------- Co-authored-by: Lennart Nachtigall <[email protected]> Co-authored-by: Felix Exner <[email protected]> Co-authored-by: Lennart Nachtigall <[email protected]> (cherry picked from commit d7e0d6d)
fmauch
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Introduced tf_prefix into log handler * added default argument to prefix --------- Co-authored-by: Lennart Nachtigall <[email protected]> Co-authored-by: Felix Exner <[email protected]> Co-authored-by: Lennart Nachtigall <[email protected]> (cherry picked from commit d7e0d6d)
fmauch
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Introduced tf_prefix into log handler * added default argument to prefix --------- Co-authored-by: Lennart Nachtigall <[email protected]> Co-authored-by: Felix Exner <[email protected]> Co-authored-by: Lennart Nachtigall <[email protected]> (cherry picked from commit d7e0d6d)
fmauch
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Introduced tf_prefix into log handler * added default argument to prefix --------- Co-authored-by: Lennart Nachtigall <[email protected]> Co-authored-by: Felix Exner <[email protected]> Co-authored-by: Lennart Nachtigall <[email protected]> (cherry picked from commit d7e0d6d)
fmauch
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Introduced tf_prefix into log handler * added default argument to prefix --------- Co-authored-by: Lennart Nachtigall <[email protected]> Co-authored-by: Felix Exner <[email protected]> Co-authored-by: Lennart Nachtigall <[email protected]> (cherry picked from commit d7e0d6d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #691
As I do not have hardware available and also do not have the ur sim setup on this system it is currently untested.