-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start ursim from lib #733
Start ursim from lib #733
Conversation
e78e9ba
to
44fa2c4
Compare
44fa2c4
to
a8ea2c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a great move to no longer have this redundancy, but i think we should adjust our documentation and tests along with the deprecation.
@RobertWilbrandt I've updated docs and tests accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great now!
* Forward start_ursim.sh to the one from the client library * Update docs and tests to start ursim from the ur_client_library script (cherry picked from commit 62f0a58)
* Forward start_ursim.sh to the one from the client library * Update docs and tests to start ursim from the ur_client_library script (cherry picked from commit 62f0a58)
This is basically to test UniversalRobots/Universal_Robots_Client_Library#155
Keeping this draft until the client_lib is merged so we can remove the rosinstall entry.