Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run robot driver test also with tf_prefix (backport #729) #751

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 21, 2023

This is an automatic backport of pull request #729 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@fmauch fmauch added the humble Relevant for humble and higher ROS versions label Jul 21, 2023
* Run robot driver test also with tf_prefix

* Use tf_prefix substitution in controllers config file

* Set default value of tf_prefix in launchfile to empty instead of '""'

---------

Co-authored-by: Robert Wilbrandt <[email protected]>
(cherry picked from commit 79bfddc)
Copy link
Collaborator

@RobertWilbrandt RobertWilbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RobertWilbrandt RobertWilbrandt merged commit 1a0f34a into humble Aug 9, 2023
6 checks passed
@RobertWilbrandt RobertWilbrandt deleted the mergify/bp/humble/pr-729 branch August 9, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Relevant for humble and higher ROS versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants