Fix linker error about a duplicate symbol

UnkindPartition · Jan 13, 2024 · 0f22df5 · 0f22df5
1 parent 0149574
commit 0f22df5
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 6 deletions.
diff --git a/ansi-terminal/CHANGELOG.md b/ansi-terminal/CHANGELOG.md
@@ -1,6 +1,11 @@
 Changes
 =======
 
+Version 1.0.2
+-------------
+
+* On Windows, fix linker error about a duplicate symbol `castUINTPtrToPtr`.
+
 Version 1.0.1
 -------------
 

diff --git a/ansi-terminal/ansi-terminal.cabal b/ansi-terminal/ansi-terminal.cabal
@@ -1,6 +1,6 @@
 Cabal-Version:       1.22
 Name:                ansi-terminal
-Version:             1.0.1
+Version:             1.0.2
 Category:            User Interfaces
 Synopsis:            Simple ANSI terminal support
 Description:         ANSI terminal support for Haskell: allows cursor movement,

diff --git a/ansi-terminal/win/System/Console/ANSI/Windows/Foreign.hs b/ansi-terminal/win/System/Console/ANSI/Windows/Foreign.hs
@@ -476,7 +476,7 @@ iNVALID_HANDLE_VALUE = castUINTPtrToPtr maxBound
 nullHANDLE :: HANDLE
 nullHANDLE = nullPtr
 
-foreign import ccall unsafe "HsWin32.h"
+foreign import ccall unsafe "HsWin32.h _ansi_terminal_castUINTPtrToPtr"
   castUINTPtrToPtr :: UINT_PTR -> Ptr a
 
 foreign import ccall unsafe "windows.h GetConsoleMode"

diff --git a/ansi-terminal/win/include/HsWin32.h b/ansi-terminal/win/include/HsWin32.h
@@ -1,9 +1,15 @@
-#ifndef __HSWIN32_H
-#define __HSWIN32_H
+#ifndef _ANSI_TERMINAL_HSWIN32_H
+#define _ANSI_TERMINAL_HSWIN32_H
 
 #define UNICODE
 #include <windows.h>
 
+/* Copied from the Win32-2.13.4.0 package, but renamed `castUINTPtrToPtr` to
+ * `_ansi_terminal_castUINTPtrToPtr`, in order to avoid problems with duplicate
+ * symbols in GHC's object files. See:
+ * https://gitlab.haskell.org/ghc/ghc/-/issues/23365.
+ */
+
 #ifndef INLINE
 # if defined(_MSC_VER)
 #  define INLINE extern __inline
@@ -12,6 +18,6 @@
 # endif
 #endif
 
-INLINE void *castUINTPtrToPtr(UINT_PTR n) { return (void *)n; }
+INLINE void *_ansi_terminal_castUINTPtrToPtr(UINT_PTR n) { return (void *)n; }
 
-#endif /* __HSWIN32_H */
+#endif /* _ANSI_TERMINAL_HSWIN32_H */