Skip to content
This repository has been archived by the owner on Aug 27, 2018. It is now read-only.

settingGateway | The Config Age #255

Merged
merged 38 commits into from
Jun 25, 2017
Merged

settingGateway | The Config Age #255

merged 38 commits into from
Jun 25, 2017

Conversation

kyranet
Copy link
Contributor

@kyranet kyranet commented Jun 5, 2017 •
edited
Loading

Proposed Semver Increment Bump: [MAJOR/MINOR/PATCH]

Well, this changes how Komada handles configs by completely...

Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

  • Now you can use any dataProvider to handle configs.
  • Added in-memory DB cache support.
  • Centralized configuration system (configGateway) which parses and handles everything.

(If Applicable) What Issue does it fix?

Fixes nothing, it's just a new feature.

@kyranet
Copy link
Contributor Author

kyranet commented Jun 7, 2017

Legendary commit.

---------- Result ------------

            Physical :  2772
              Source :  2400
             Comment :  96
 Single-line comment :  27
       Block comment :  69
               Mixed :  5
               Empty :  281
               To Do :  0

Number of files read :  65

------------------------------

@kyranet kyranet changed the title [WIP] configGateway | The Config Age [WIP] settingGateway | The Config Age Jun 10, 2017
@kyranet kyranet changed the title [WIP] settingGateway | The Config Age settingGateway | The Config Age Jun 25, 2017
@kyranet
Copy link
Contributor Author

kyranet commented Jun 25, 2017

Needs testing, a bit more of documentation, an Array support (so I can re-enable disabledCommands).

@kyranet kyranet added SEM: Patch and removed WIP labels Jun 25, 2017
@kyranet kyranet mentioned this pull request Jun 25, 2017
Closed
@kyranet kyranet added WIP and removed WIP labels Jun 25, 2017
bdistin
bdistin approved these changes Jun 25, 2017
View reviewed changes
Copy link
Contributor

@bdistin bdistin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to test out good on my end

@bdistin bdistin merged commit f5838e6 into indev Jun 25, 2017
@bdistin bdistin deleted the config-rewrite branch June 25, 2017 21:35
@kyranet kyranet mentioned this pull request Feb 15, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdistin bdistin bdistin approved these changes

Assignees

@CyberiumShadow CyberiumShadow

@kyranet kyranet

Labels
Meta: Refactor SEM: Minor SEM: Patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyranet @bdistin @UnseenFaith @CyberiumShadow