Skip to content
This repository has been archived by the owner on Aug 27, 2018. It is now read-only.

Komada Extendables #343

Merged
merged 3 commits into from
Sep 2, 2017
Merged

Komada Extendables #343

merged 3 commits into from
Sep 2, 2017

Conversation

UnseenFaith
Copy link
Owner

Proposed Semver Increment Bump: [MAJOR/MINOR/PATCH]

Patch

Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

  • Allows for Komada extendables in the same fashion as Klasa.
exports.conf = {
   type: "method",
   method: "ping",
   appliesTo: ["Client"],
   komada: true
 };

exports.extend = function () { return console.log("Pong!") }; // <client>.ping();

kyranet
kyranet approved these changes Sep 2, 2017
View reviewed changes
Copy link
Contributor

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@UnseenFaith UnseenFaith merged commit cdabfbd into UnseenFaith:master Sep 2, 2017
@UnseenFaith UnseenFaith deleted the extendable-changes branch September 2, 2017 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UnseenFaith @kyranet