Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "types" entries to the "exports" property of package.json, to allow consumption from Typescript with the new Node16 module resolution strategy #1602

Closed
Duncan3142 opened this issue May 17, 2022 · 1 comment

Comments

@Duncan3142
Copy link

Is your feature request related to a problem? Please describe.

I'm unable to consume "graphql-scalars" from Typescript 4.7, when module resolution is set to Node16

Describe the solution you'd like

Add "types" entries to the "exports" property of package.json

Describe alternatives you've considered

None

Additional context

The following would suffice

"exports": {
  ".": {
    "types": "./index.d.ts",
    "require": "./index.js",
    "import": "./index.mjs"
  },
  "./*": {
    types": "./*.d.ts",
    "require": "./*.js",
    "import": "./*.mjs"
   },
  "./package.json": "./package.json"
}
@ardatan
Copy link
Collaborator

ardatan commented Mar 24, 2023

Available in the latest release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants