fix(ts): Add types to exports fields #1628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chentsulin is attempting to deploy a commit to the The Guild Team on Vercel. A member of the Team first needs to authorize it. |
ruckonic
approved these changes
Jun 20, 2022
|
Any reason this can't be merged? Also having typescript errors when using esm. |
|
@Urigo Is there any chance to move this forward? This blocks people using TS ESM with graphql-scalars. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RunAge
approved these changes
Sep 27, 2022
|
Done with 5bf309c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1602
See https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing for more details.
Type of change