Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/#62 morph features #63

Merged
merged 5 commits into from
Aug 26, 2022
Merged

Conversation

@nagadomi
Copy link

Is there any reason to remove BIND/UNIND operator from Morph Tool panel?
I think the usability of the panel should be kept.

@nagadomi
Copy link

Also, why is compatible_with_old_version_mmd_tools() called from save_pre instead of load_post?
Is it safe to work with old blend files without saving them after loading?

@UuuNyaa
Copy link
Owner Author

UuuNyaa commented Aug 26, 2022

@nagadomi Thank you for your review 😃

Is there any reason to remove BIND/UNIND operator from Morph Tool panel?
I think the usability of the panel should be kept.

I misunderstood the function of UILayout.operator_enum.
I will restore BIND/UNBIND operations on the menu.

Also, why is compatible_with_old_version_mmd_tools() called from save_pre instead of load_post?
Is it safe to work with old blend files without saving them after loading?

It calls update_mmd_morph() at load_post and compatible_with_old_version_mmd_tools() at save_pre.
update_mmd_morph() migrates the old add-on data structure to the pull request's data structure.
And compatible_with_old_version_mmd_tools() re-migrates to the old add-on data structure.

In the future, compatible_with_old_version_mmd_tools() call will be discontinued.

@One-sixth
Copy link

@UuuNyaa I reviewed it and it looks no problem.

And I found some new similar bugs. They can be repaired at a later time.

When another collection is selected, click the Model Production Panel 's Chop button.
When another collection is selected, click the Uuunyaa Physics Panel 's mmd_uuunyaa_tools_show_cloths button.

@nagadomi
Copy link

@UuuNyaa
Thank you for the description of update_mmd_morph. I only looked at the diff summary and missed it.

@UuuNyaa UuuNyaa merged commit 27e1872 into main Aug 26, 2022
@UuuNyaa UuuNyaa deleted the enhancement/#62_morph_features branch August 26, 2022 21:38
@UuuNyaa
Copy link
Owner Author

UuuNyaa commented Aug 26, 2022

@One-sixth and @nagadomi Thank you for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants