Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid encoding #45

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Fix invalid encoding #45

merged 1 commit into from
Jan 21, 2024

Conversation

aiaimimi0920
Copy link
Contributor

@fire fire changed the title fix invalid encoding Fix invalid encoding Jan 20, 2024
fire
fire approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasoning from the comment follow to conclusion.

@aiaimimi0920
Copy link
Contributor Author

aiaimimi0920 commented Jan 21, 2024 •
edited
Loading

Reasoning from the comment follow to conclusion.

Because English is not my native language, do you mean to ask me to explain why I need to modify it this way? Or is it the process of discovering problems?

@fire
Copy link
Member

fire commented Jan 21, 2024

I mean it looks good. 👍

@Ughuuu Ughuuu merged commit 564dbc8 into V-Sekai:main Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aiaimimi0920 @fire @Ughuuu