Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package namespace bugs #82

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

Tcenova
Copy link
Contributor

@Tcenova Tcenova commented Jul 29, 2024

Bug Fixes

Thomas Cenova added 2 commits July 29, 2024 09:20
…entifier. This caused issues where elements would not be found if identifier and normalizedIdentifier did not match.
…onstants), then this code would fail. Adding a check to see if the _normalizedIdentifiers attr exists, and if so add a entry for each identifier
Copy link
Member

@Paebbels Paebbels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the proposed isinstance to check for the mixin been used to offer either a single name or multiple names.

pyVHDLModel/__init__.py Outdated Show resolved Hide resolved
pyVHDLModel/__init__.py Outdated Show resolved Hide resolved
@Paebbels Paebbels added the bug Something isn't working label Jul 29, 2024
@Paebbels Paebbels merged commit c19d6e0 into VHDL:dev Jul 29, 2024
1 of 2 checks passed
@Paebbels
Copy link
Member

@Tcenova did the merged version run in your report by a GitHub pipeline?

Since GitHub got stupid about pipelines, I can't see any pipeline running for contributions to check for correctness. I need to merge it and see it fail in my account. Previously, it started a pipeline in the fork and displayed the results in my pipeline overview too.

@Paebbels
Copy link
Member

I pushed a fixed version to dev.

@Paebbels Paebbels mentioned this pull request Jul 29, 2024
@Tcenova
Copy link
Contributor Author

Tcenova commented Jul 29, 2024

@Tcenova did the merged version run in your report by a GitHub pipeline?

I am not sure. I have never used GitHub pipelines before. Where would I check?

@Paebbels
Copy link
Member

I checked here: https://github.com/Tcenova/pyVHDLModel/actions

Hmmm there is no pipeline. WTF has GitHub changed ... This explains why I see no results, but why does it not launch in your account/fork...?

@Tcenova
Copy link
Contributor Author

Tcenova commented Jul 29, 2024

Ah. Because it defaults to not running in forks. I get the message:

Workflows aren’t being run on this forked repository
Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

I get an option to enable them on the fork. I will do so, so hopefully it will run if I end up submitting other PRs.

I do see a code check on this PR under the "Checks" tab which links to: https://app.codacy.com/gh/VHDL/pyVHDLModel/pull-requests/82/issues

@Paebbels
Copy link
Member

Please activate and lets see if it works next time.

The latter was fixed by ma new push. the f-string can be converted to a normal string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants