-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image encoder base #61
Conversation
e61ac96
to
dc57a9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it looks good, thanks! Please address my comments!
|
||
import numpy as np | ||
import pandas as pd | ||
from skimage.color import gray2rgb, rgb2gray, rgba2rgb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The skimage lib should be loaded as an optional dependency, otherwise it will raise an error because it's not installed in the default version of alpha-automl
alpha_automl/resource/Untitled.ipynb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be in the resource
folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the d3mIndex column. Avoid to use the name learningData.csv
. Use something more descriptive, e.g. digits.csv, etc. It's not necessary to have the folder tables
. Change the name image_dataset_2
to digits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add only one example for image classification. Add the link to download the dataset in the jupyter notebook. This link should contain the trian_data.csv and test_data.csv files (use the same names that we have in the other example to be consistent). Avoid to split the data in the jupyter notebook. The less code we put in our example, the better.
3a929ba
to
8dbd6b4
Compare
…CLIP; update for semi supervised tasks; add selfie notebook; add source for dataset; add testcases
8dbd6b4
to
ea19fa1
Compare
I made some minor changes. Feel free to merge it. |
I fixed some bugs and new it is ready to merge |
No description provided.