Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image encoder base #61

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Add image encoder base #61

merged 6 commits into from
Oct 11, 2023

Conversation

EdenWuyifan
Copy link
Collaborator

No description provided.

@EdenWuyifan EdenWuyifan force-pushed the image_encoder branch 3 times, most recently from e61ac96 to dc57a9d Compare September 14, 2023 17:16
@EdenWuyifan EdenWuyifan changed the title [WIP] Add image encoder base Add image encoder base Sep 26, 2023
Copy link
Collaborator

@roquelopez roquelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good, thanks! Please address my comments!


import numpy as np
import pandas as pd
from skimage.color import gray2rgb, rgb2gray, rgba2rgb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skimage lib should be loaded as an optional dependency, otherwise it will raise an error because it's not installed in the default version of alpha-automl

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be in the resource folder

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not necessary

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the d3mIndex column. Avoid to use the name learningData.csv. Use something more descriptive, e.g. digits.csv, etc. It's not necessary to have the folder tables. Change the name image_dataset_2 to digits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add only one example for image classification. Add the link to download the dataset in the jupyter notebook. This link should contain the trian_data.csv and test_data.csv files (use the same names that we have in the other example to be consistent). Avoid to split the data in the jupyter notebook. The less code we put in our example, the better.

@EdenWuyifan EdenWuyifan force-pushed the image_encoder branch 2 times, most recently from 3a929ba to 8dbd6b4 Compare October 9, 2023 23:17
…CLIP; update for semi supervised tasks; add selfie notebook; add source for dataset; add testcases
@roquelopez
Copy link
Collaborator

I made some minor changes. Feel free to merge it.

@EdenWuyifan
Copy link
Collaborator Author

I fixed some bugs and new it is ready to merge

@EdenWuyifan EdenWuyifan merged commit a0b7d05 into devel Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants