Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add log record for user actions, change heatmap to horizontal #70

Closed
wants to merge 1 commit into from

Conversation

EdenWuyifan
Copy link
Collaborator

No description provided.

@roquelopez roquelopez changed the title Add log record for user actions, change heatmap to horizontal feat: Add log record for user actions, change heatmap to horizontal Jul 15, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@aecio aecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, I only left some minor comments. Howerver, I'm not sure if we should include this notebook in this repository. I think the notebooks in the examples directory are supposed to be more informative/educational/documentation about the library. This one is structured to be used in a paper study, so maybe we should find another place and repository to add paper-related notebooks.

Regarding the visualization and interactions, I'll send more feedback later in private.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
bdikit/visualization/schema_matching.py Outdated Show resolved Hide resolved
@roquelopez roquelopez deleted the eden/heatmap_loggings branch September 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants