feat: Adding embedding cache for gdc case #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aecio
reviewed
Jul 17, 2024
bdikit/mapping_algorithms/scope_reducing/_algorithms/contrastive_learning/cl_api.py
Outdated
Show resolved
Hide resolved
bdikit/mapping_algorithms/scope_reducing/_algorithms/contrastive_learning/cl_api.py
Outdated
Show resolved
Hide resolved
bdikit/mapping_algorithms/scope_reducing/_algorithms/contrastive_learning/cl_api.py
Outdated
Show resolved
Hide resolved
bdikit/mapping_algorithms/scope_reducing/_algorithms/contrastive_learning/cl_api.py
Outdated
Show resolved
Hide resolved
|
@EduardoPena Just tested and it seems to be working fine here. I think my last concern now is what happens when we update the model. We should probably include the model name as a subdirectory in the cache file path so that we don't reuse the cached embedding of a previous model. |
aecio
changed the title
|
@aecio , the last commit integrates the model name as a parameter for the cache. Let me know if we are ready to merge into devel. |
|
When merging, I would use the squash option to merge everything in a single clean commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #51 issue. This feature allows fast interactions with the user, for example, from ~30s to ~1.5s when matching the 740 columns of GDC using the CL approach. We might want to add support for arbitrary data sets as well, but I am not sure.